Re: [PATCH] Avoid calling down_read and down_write during startup

[Benjamin LaHaise]

On Thu, Feb 23, 2006 at 04:16:31PM -0800, Andrew Morton wrote:
> down_write() unconditionally (and reasonably) does local_irq_enable() in
> the uncontended case.  And enabling local interrupts early in boot can
> cause crashes.

Why not do a down_write_trylock() instead first?  Then the code doesn't 
have the dependancy on system_state, which seems horribly fragile.

		-ben
-- 
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here 
and they've asked us to stop the party."  Don't Email: <dont@xxxxxxxxx>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/