Re: [PATCH, RFC] sysfs: relay channel buffers as sysfs attributes

From: Christoph Hellwig
Date: Mon Feb 20 2006 - 09:15:14 EST


On Mon, Feb 20, 2006 at 08:05:56AM -0500, Mathieu Desnoyers wrote:
> * LTTng does have its own ltt_poll and ltt_ioctl that are all what is needed to
> control the interaction with the file (along with the relayfs mmap/unmap).
>
> In this scenario, the sysfs relay attribute creation would look like :
>
> - create an empty attr
> - fill some of attr members
> - sysfs_create_relay_file(kobj, attr);
> (it will overwrite some attr members : kobj, rchan, rchan_buf)
> * set specific LTTng file operations on the inode

defintily not on sysfs. sysfs doesn't allow drivers to modify the
file operations for good reasons. it'll probably work the same as-is
when you use the rely file operations on debugfs or a custom filesystem,
although you're code will have zero chance to get merged when it modifies
an existing file operations struct or adds an ioctl.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/