Re: [PATCH 7/8] don't mangle INQUIRY if cmddt or evpd bits are set

From: Stefan Richter
Date: Mon Feb 13 2006 - 11:19:00 EST


Al Viro wrote on 2006-02-09:
On Wed, Feb 08, 2006 at 11:35:18PM +0100, Stefan Richter wrote:
...
not a single one of these bridges is affected by the code change since the additional expression which was added always evaluates true.

The hell it does. Try scsiinfo -s and you'll see. All INQUIRY generated
by scsi midlayer have both flags set to 0. Userland ones do not;
...

OK, tested scsiinfo now with 9 bridges (8 or 7 different chips).
The patch obviously works as expected.

Jody, are you going to channel the patch through your tree?

BTW, a Prolific based enclosure indeed seems to be unable to handle
CD-ROMs after scsiinfo treatment. An enclosure based on an old
revision of TI StorageLynx apparently causes mode_sense -> check
condition/ unit attention loops when scsiinfo tries to access some
mode page.
--
Stefan Richter
-=====-=-==- --=- -==-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/