Re: 2.6.16-rc2-mm1 -- BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()

[Stefan Richter]

Andrew Morton wrote:
> > > That's a -mm-only warning telling you that get_phy_reg() is doing a
> > > one-millisecond-or-more busywait while local interrupts are disabled.
...
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc2/2.6.16-rc2-mm1/broken-out/debug-warn-if-we-sleep-in-an-irq-for-a-long-time.patch

So that's why when I heard of this issue the first time, it was about 
Redhat/ Fedora Core kernels. But even though this issue is very old, no 
bug report got through to linux1394-devel until December 2005.

BTW, why not swap the order of expressions:
		WARN_ON(!(warned++) && in_irq()); 	\
--
Stefan Richter
-=====-=-==- --=- -=-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/