Re: msync() behaviour broken for MS_ASYNC, revert patch?

[Andrew Morton]

Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
> Andrew Morton wrote:
> > Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
> 
> >>and had no need for a MS_SYNC anywhere in the meantime.
> >>If you did have the need for MS_SYNC, then kicking off the IO
> >>ASAP is going to be more efficient.
> > 
> > 
> > Of course these sorts of applications don't know what they'll be doing in
> > the future.  Often the location of the next update is driven by something
> > which came across the network.
> > 
> 
> If there is no actual need for the application to start a write (eg
> for data integrity) then why would it ever do that?

To get the data sent to disk in a reasonable amount of time - don't leave it
floating about in memory for hours or days.

> > 
> > There's no need to do that.   Look:
> > 
> > msync(MS_ASYNC): propagate pte dirty flags into pagecache
> > 
> > LINUX_FADV_ASYNC_WRITE: start writeback on all pages in region which are
> > dirty and which aren't presently under writeback.
> > 
> > LINUX_FADV_WRITE_WAIT: wait on writeback of all pages in range.
> > 
> > I think that covers all conceivable scenarios.  One thing per operation,
> > leave the decisions and tuning up to the application.  And it gives us two
> > operations which are also useful in association with regular write().
> > 
> 
> Oh yeah it is easy if you want to define some more APIs and do
> it in a Linux specific way.
> 
> But the main function of msync(MS_ASYNC) AFAIK is to *start* IO.
> Why do we care so much if some application goes stupid with it?

Because delaying the writeback to permit combining is a good optimisation.

The alternative of not starting new writeout of a dirty page if that page
happens to be under writeout at the time is neither one nor the other. 
With that proposal, if the application really wants IO started right now,
then it's going to have to use msync(MS_SYNC).

> Why not introduce a linux specific MS_flag to propogate pte dirty
> bits?

That's what MS_ASYNC already does.  We're agreed that something needs to
change and we're just discussing what that is.  I'm proposing something
which is complete and flexible.



Another point here is that msync(MS_SYNC) starts writeout of _all_ dirty
pages in the file (as MS_ASYNC used to do) and it waits upon writeback of
the whole file.  That's quite inefficient for an app which has lots of
threads writing to and msync()ing the same MAP_SHARED file.

We could easily enough convert msync() to only operate on the affected
region of the (non-linearly-mapped) file.  But I don't think we can do that
now, because people might be relying upon the side-effects.

The fadvise() extensions allow us to fix this.  And we've needed them for
some time for regular write()s anyway.  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/