Re: [PATCH] add execute_in_process_context() API

[Andi Kleen]

James Bottomley <James.Bottomley@xxxxxxxxxxxx> writes:

In general this seems like a lot of code for a simple problem.
It might be simpler to just put the work structure into the parent
object and do the workqueue unconditionally


> +	if (unlikely(!wqw)) {
> +		printk(KERN_ERR "Failed to allocate memory\n");
> +		WARN_ON(1);

WARN_ON for GFP_ATOMIC failure is bad. It is not really a bug.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/