[PATCH 2.6.16-rc2-git2-gkh] aoe [2/3]: don't request ATA device ID on ATA error

From: Ed L. Cashin
Date: Tue Feb 07 2006 - 11:44:07 EST


Signed-off-by: "Ed L. Cashin" <ecashin@xxxxxxxxxx>

On an ATA error response, take the device down instead of
sending another ATA device identify command.

diff -upr 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c
--- 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c 2006-02-06 17:41:05.000000000 -0500
+++ 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c 2006-02-06 17:56:59.000000000 -0500
@@ -517,6 +517,8 @@ aoecmd_ata_rsp(struct sk_buff *skb)
ahout = (struct aoe_atahdr *) (f->data + sizeof(struct aoe_hdr));
buf = f->buf;

+ if (ahout->cmdstat == WIN_IDENTIFY)
+ d->flags &= ~DEVFL_PAUSE;
if (ahin->cmdstat & 0xa9) { /* these bits cleared on success */
printk(KERN_CRIT "aoe: aoecmd_ata_rsp: ata error cmd=%2.2Xh "
"stat=%2.2Xh from e%ld.%ld\n",
@@ -549,7 +551,6 @@ aoecmd_ata_rsp(struct sk_buff *skb)
return;
}
ataid_complete(d, (char *) (ahin+1));
- d->flags &= ~DEVFL_PAUSE;
break;
default:
printk(KERN_INFO "aoe: aoecmd_ata_rsp: unrecognized "


--
"Ed L. Cashin" <ecashin@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/