Re: [patch -mm4] i386 cpu hotplug: don't access freed memory

[Andrew Morton]

Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx> wrote:
>
> @@ -160,10 +162,17 @@ static void __cpuinit get_cpu_vendor(str
>  				c->x86_vendor = i;
>  				if (!early)
>  					this_cpu = cpu_devs[i];
> -				break;
> +				return;
>  			}
>  		}
>  	}
> +	if (!printed) {
> +		printed++;
> +		printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n");
> +		printk(KERN_ERR "CPU: Your system may be unstable.\n");
> +	}
> +	c->x86_vendor = X86_VENDOR_UNKNOWN;
> +	this_cpu = &default_cpu;

Well that's a worry.  Under what circumstances (if any) will this final bit
of code get executed?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/