Re: [PATCH 00/04] Add DSA key type

From: David Härdeman
Date: Sat Jan 28 2006 - 06:29:02 EST


On Fri, Jan 27, 2006 at 11:28:56PM +1100, Herbert Xu wrote:
On Fri, Jan 27, 2006 at 08:23:45AM +0100, David H?rdeman wrote:
On Fri, Jan 27, 2006 at 12:22:31PM +1100, Herbert Xu wrote:
The asymmetric encryption support should be done inside the crypto/
framework rather than as an extension to the key management system.

It is done inside the crypto/ framework. crypto/dsa.c implements the DSA signing as a hash crypto algorithm (since a DSA signature is two 160-bit integers, the result has a fixed size).

Right. I mistook the name encrypt to mean generic asymmetric encryption.
Now I see that it is simply an interface to the signature algorithm.
This is fine by me. However, wouldn't "sign" be a better name for it?


I don't know, the function which is performed upon the data is keytype-specific (i.e. with the dsa key the data is signed, with another key type it might be encrypted, etc). So perhaps the operation should be given a more generic name such as "crypto".

Re,
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/