Re: remove incorrect dependancy on CONFIG_APM

[Adrian Bunk]

On Tue, Dec 20, 2005 at 04:21:27PM -0500, Dave Jones wrote:
> 
> >From the PM_LEGACY Kconfig description..
> 
> "Support for pm_register() and friends."
> 
> Note, no mention of 'make apm stop working'.
> 
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
> 
> --- linux-2.6.14/arch/i386/Kconfig~	2005-12-20 16:19:17.000000000 -0500
> +++ linux-2.6.14/arch/i386/Kconfig	2005-12-20 16:19:21.000000000 -0500
> @@ -710,7 +710,7 @@ depends on PM && !X86_VISWS
>  
>  config APM
>  	tristate "APM (Advanced Power Management) BIOS support"
> -	depends on PM && PM_LEGACY
> +	depends on PM
>...

This doesn't compile:

<--  snip  -->

...
  CC      arch/i386/kernel/apm.o
arch/i386/kernel/apm.c: In function 'apm_init':
arch/i386/kernel/apm.c:2304: error: 'pm_active' undeclared (first use in this function)
arch/i386/kernel/apm.c:2304: error: (Each undeclared identifier is reported only once
arch/i386/kernel/apm.c:2304: error: for each function it appears in.)
arch/i386/kernel/apm.c: In function 'apm_exit':
arch/i386/kernel/apm.c:2410: error: 'pm_active' undeclared (first use in this function)
make[1]: *** [arch/i386/kernel/apm.o] Error 1

<--  snip  -->


If PM_LEGACY causes user confusion for APM users, commit 
bca73e4bf8563d83f7856164caa44d5f42e44cca should be reverted.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/