Re: [PATCH 2.6-git] SPI: add set_clock() to bitbang

[David Brownell]

> >This is actually not needed.  Clocks are set through the setup() method
> ...
>
> Where is it supposed to call setup? I guess it's anyway gonna be 
> per-transfer, right?
> Or am I missing something?

When the device is created, the core calls setup() to get things like
chipselect polarity sorted out and put into the inactive state.   That
matches the board-specific defaults associated with that device, which
would be a function of voltage, routing, and more.

And from then on, it'd be rare to ever call setup() again ... though
drivers certainly could do that between spi_message interactions with
a given device.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/