Re: [PATCH 02/02] RT: plist namespace cleanup

[Daniel Walker]

On Thu, 2005-12-22 at 21:24 +0300, Oleg Nesterov wrote:
> Daniel Walker wrote:
> > 
> > On Thu, 2005-12-22 at 17:10 +0300, Oleg Nesterov wrote:
> > > Daniel Walker wrote:
> > > >
> > > >         Make the plist namespace consistent.
> > >
> > > I think plist_head is much better than pl_head.
> > >
> > > However I think plist_empty/plist_unhashed is more accurate
> > > than plist_head_empty/plist_node_empty, but I am rather
> > > agnostic to naming.
> > 
> > unhashed seems very meaningless . We're not hashing anything.
> 
> Still we already have hlist_empty/hlist_unhashed

That's more connected with hashing , since that's were it gets used. In
this case we're not hashing , or even related to hashing. 

> > > Daniel, it would be great if you can check that kernel/rt.o
> > > was not changed after rename (as it should be).
> > 
> > I didn't check, but I made no code changes so it should be any
> > different.
> 
> That is why I asked. It is very easy to make a mistake by accident
> while doing trivial changes, but it is not easy to notice.

I reviewed it prior to submitting it . 

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/