Re: [patch 3/3] mutex subsystem: move the core to the new atomic helpers

[Ingo Molnar]

* Nicolas Pitre <nico@xxxxxxx> wrote:

> This patch moves the core mutex code over to the atomic helpers from 
> previous patch.  There is no change for i386 and x86_64, except for 
> the forced unlock state that is now done outside the spinlock (doing 
> so doesn't matter since another CPU could have locked the mutex right 
> away even if it was unlocked inside the spinlock).  This however 
> brings great improvements on ARM for example.

i'm wondering how much difference it makes on ARM - could you show us 
the before and after disassembly of the fastpath, to see the 
improvement?

your patches look OK to me, only one small detail sticks out: i'd 
suggest to rename the atomic_*_contended macros to be arch_mutex_*_..., 
i dont think any other code can make use of it. Also, it would be nice 
to see the actual ARM patches as well, which make use of the new 
infrastructure.

could you resend them against my latest queue that i just posted? I'll 
look at integrating them tomorrow.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/