Re: [RFC: 2.6 patch] Makefile: sound/ must come before drivers/

From: Takashi Iwai
Date: Wed Dec 21 2005 - 09:18:49 EST


At Tue, 20 Dec 2005 14:09:03 -0800 (PST),
Linus Torvalds wrote:
>
>
>
> On Tue, 20 Dec 2005, Adrian Bunk wrote:
> >
> > Thinking about this, what about the patch below?
> >
> > I don't know whether this might break anything else, but it fixes my
> > problem.
>
> I'd be much more worried about this than about your patch that just
> modifies one driver.
>
> Basically, this would make _all_ sound drivers initialize before the other
> drivers, and that just makes me suspect you'll have a lot of new bugs that
> get uncovered by the fact that the configuration changed radically.
>
> So I'd much rather either fix one single sound driver (that can't mess up
> anything else), or fix the sound _core_ to just initialize in the right
> place. Moving _all_ sound drivers earlier sounds risky as hell, for no
> good reason.

Agreed, it looks too radical at this stage.

Another workaround is to move the relevant module to sound/* directory
in order to get a sane initialization order. It's nothing but a
workaround, though.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/