Re: [PATCH rc6] block: Fix CDROMEJECT to work in more cases

[Linus Torvalds]

On Tue, 20 Dec 2005, Jens Axboe wrote:
> 
> There _was_ a bug in the SCSI layer, because it had logic like this:
> 
>         if (rq_data_dir(req) == WRITE)
>                 DMA_TO_DEVICE
>         else if (req->data_len)
>                 DMA_FROM_DEVICE
>         else
>                 DMA_NONE
> 
> which was buggy, because for it to transfer data to the device, both the
> direction bit _and_ a data length must be set.

So this is fixed? Is that the iPod panic fix, or something else?

If so, I'll drop that patch (although the "allow_removal" part of it 
sounds sane to me still.. comments?)

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/