Re: [PATCH rc5-rt2 0/3] plist: alternative implementation

[Daniel Walker]

On Tue, 2005-12-20 at 15:38 +0100, Ingo Molnar wrote:
> * Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> 
> > Rediff against patch-2.6.15-rc5-rt2.
> > 
> > Nothing was changed except s/plist_next_entry/plist_first_entry/ to 
> > match the current naming.
> 
> thanks Oleg, your patches look good to me, and it's a worthwile cleanup 
> to make plist.h ops behave more like normal list.h ops. The new ops 
> should be documented, but otherwise it looks OK.

I think there is a bug in the new plist_add() , which was in the
original code. It doesn't properly handle the new maximum node scenario,
or INT_MAX . 

If the list is 1 2 3 4

and you insert 5 , you'll end up with the list 1 2 3 5 4 . Or something
like that .


Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/