Re: [PATCH] mips: namespace pollution: dump_regs() -> elf_dump_regs()

From: Maciej W. Rozycki
Date: Tue Dec 20 2005 - 07:15:34 EST


On Mon, 19 Dec 2005, Al Viro wrote:

> > I guess drivers should be fixed not to use generic names in the first
> > place -> s/dump_regs/frobnicator_dump_regs/, etc.
>
> No. If nothing else, it's far less work to keep the headers reasonably
> clean than to slap prefices on every damn static-in-file function

That's the duty of the respective maintainers. You don't expect one to
have a private printk() (or whatever -- pick your favourite) function in a
driver and demand the global one to be renamed so that their own one keeps
working.

> out there. Leads to more readable code in drivers, too...

Well, that's just a reason to keep namespace prefixes short...

Maciej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/