Re: [spi-devel-general] Re: [PATCH/RFC] SPI: async message handing library update

[David Brownell]

On Monday 19 December 2005 7:40 am, dmitry pervushin wrote:
> On Sun, 2005-12-18 at 10:59 -0800, David Brownell wrote:
> >                         chipselect = !t->cs_change;
> >                         if (chipselect);
> >                                 continue;
> > 
> >                         bitbang->chipselect(spi, 0);
> > 
> >                         /* REVISIT do we want the udelay here instead?
> > */
> >                         msleep(1);
> Ohhh. Have you intentionally put the semicolon after "if
> (chipselect)" ? 

Nope.  Good catch ... haven't had a chance to try that yet with that driver;
not all drivers actually need to drop chipselect like that.

Any other comments about that approach to the "let someone else manage the
queue"?  This one's more clearly "implementation utilities" than what you had
seemed to be talking about before, but I think it does address a point where
I think we were agreeing:  it should be easy for people to whip together a
controller driver by providing just some lower level I/O calls.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/