Re: [patch 04/15] Generic Mutex Subsystem, add-atomic-call-func-x86_64.patch

From: Ingo Molnar
Date: Mon Dec 19 2005 - 23:31:05 EST



* David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

> On Mon, 2005-12-19 at 09:49 -0800, Zwane Mwaikambo wrote:
> > Hi Ingo,
> > Doesn't this corrupt caller saved registers?
>
> Looks like it. I _really_ don't like calling functions from inline
> asm. It's not nice. Can't we use atomic_dec_return() for this?

we can use atomic_dec_return(), but that will add one more instruction
to the fastpath. OTOH, atomic_dec_return() is available on every
architecture, so it's a really tempting thing. I'll experiment with it.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/