[patch] fs/smbfs/proc.c: fix data corruption in smb_proc_setattr_unix()

From: Adrian Bunk
Date: Sun Dec 18 2005 - 15:06:17 EST


From: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>


This patch fixes a data corruption in smb_proc_setattr_unix()
(smb_filetype_from_mode() returns an u32, and there are only four bytes
reserved for it in data.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>


--- linux-2.6.14-rc3-git3/fs/smbfs/proc.c 2005-10-04 19:24:37.000000000 +1000
+++ .6877.trivial/fs/smbfs/proc.c 2005-10-04 19:29:50.000000000 +1000
@@ -3113,7 +3113,7 @@ smb_proc_setattr_unix(struct dentry *d,
LSET(data, 32, SMB_TIME_NO_CHANGE);
LSET(data, 40, SMB_UID_NO_CHANGE);
LSET(data, 48, SMB_GID_NO_CHANGE);
- LSET(data, 56, smb_filetype_from_mode(attr->ia_mode));
+ DSET(data, 56, smb_filetype_from_mode(attr->ia_mode));
LSET(data, 60, major);
LSET(data, 68, minor);
LSET(data, 76, 0);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/