Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile

From: Sam Ravnborg
Date: Sun Dec 18 2005 - 14:54:40 EST


On Fri, Dec 16, 2005 at 03:48:55PM -0800, Roland Dreier wrote:
> @@ -0,0 +1,15 @@
> +EXTRA_CFLAGS += -Idrivers/infiniband/include
If this is needed then some header files should be moved to include/rdma

> +
> +ipath_core-objs := ipath_copy.o ipath_driver.o \
> + ipath_dwordcpy.o ipath_ht400.o ipath_i2c.o ipath_layer.o \
> + ipath_lib.o ipath_mlock.o
> +
> +ib_ipath-objs := ipath_mad.o ipath_verbs.o

Please use:
ipath_core-y := ...
ib_ipath-y := ...

Use of -y let you do better Kconfig selection in the makefile, and is
preferred compared to -objs

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/