Re: [PATCH 1/5] - Fix 64-bit compile warnings

From: Al Viro
Date: Sun Dec 18 2005 - 10:56:10 EST


On Sun, Dec 18, 2005 at 01:23:45PM -0200, Mauro Carvalho Chehab wrote:
> Fix 64-bit compile warnings
> diff --git a/drivers/media/common/saa7146_hlp.c b/drivers/media/common/saa7146_hlp.c
> index ec52dff..be34ec4 100644
> --- a/drivers/media/common/saa7146_hlp.c
> +++ b/drivers/media/common/saa7146_hlp.c
> @@ -562,7 +562,7 @@ static void saa7146_set_position(struct
>
> int b_depth = vv->ov_fmt->depth;
> int b_bpl = vv->ov_fb.fmt.bytesperline;
> - u32 base = (u32)vv->ov_fb.base;
> + u32 base = (u32)(unsigned long)vv->ov_fb.base;

That's not "fix", that's "confuse gcc so it doesn't notice the problem
anymore"...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/