Re: [PATCH] Input: fix an OOPS in HID driver

From: Dmitry Torokhov
Date: Sat Dec 17 2005 - 11:43:20 EST


On Saturday 17 December 2005 05:22, Vojtech Pavlik wrote:
> On Fri, Dec 16, 2005 at 09:31:04PM -0500, Dmitry Torokhov wrote:
> > Subject:
> >
> > This patch fixes an OOPS in HID driver when connecting simulation
> > devices generating unknown simulation events.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
>
> Yup, needed indeed. I'm not sure if we want an 'unknown': 'ignore'
> might be safer.

Well, 'unknown' restores the previous behavior (before simulation codes
were added to the driver) so it is pretty safe, however 'ignore' is indeed
more correct I think.

I will send an updated patch. Linus, if you already applied the original
one just ignore the new one - we can change it post 2.6.15 when we add
more simulation codes to HID driver.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/