Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

From: Linus Torvalds
Date: Thu Dec 15 2005 - 14:37:50 EST




On Thu, 15 Dec 2005, Andrew Morton wrote:
>
> They should be renamed to DEFINE_* while we're there. A "declaration" is
> "this thing is defined somewhere else". A "definition" is "this thing is
> defined here".

Yeah, I confuse the two. Although by now I've gotten so used to DECLARE_
that at least me personally I like it.

> > I wouldn't be adverse to doing that
>
> argh.

Heh. At least there's only 310 DECLARE_MUTEX* references in the whole
kernel. So we're not actually talking about a huge patch.

It's also fairly simple to work with in out-of-tree drivers, since it's
always bound to be a #define, so you can do things like

#ifndef DECLARE_SEM_MUTEX
#define DECLARE_SEM_MUTEX(x) DECLARE_MUTEX(x)
#endif

or something.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/