Re: [linux-usb-devel] Re: 2.6.15-rc5-mm2: ehci_hcd crashes on load sometimes

From: Rafael J. Wysocki
Date: Tue Dec 13 2005 - 17:37:33 EST


On Tuesday, 13 December 2005 23:22, David Brownell wrote:
> On Tuesday 13 December 2005 2:10 pm, Rafael J. Wysocki wrote:
> > On Tuesday, 13 December 2005 07:52, David Brownell wrote:
> > > >
> > > > if ((status & STS_PCD) && device_may_wakeup(&hcd->self.root_hub->dev)) {
> > >
> > > What happens if you make that line read
> > >
> > > if ((status & STS_PCD) != 0) {
> > >
> > > and ignore the root hub thing?
> >
> > So far, so good. It works and hasn't triggered the oops yet. I'll report if there's
> > anything wrong with it.
>
> I suspect that should be safe to merge for 2.6.15, and it might be
> worth considering that. You were using kexec() right?

No, I was not. Why would that be important?

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/