Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y

[Russell King]

On Tue, Dec 13, 2005 at 06:38:36PM +0100, Geert Uytterhoeven wrote:
> On Tue, 13 Dec 2005, Russell King wrote:
> > If, in order to have a working platform configuration, they deem that
>                          ^^^^^^^
> > CONFIG_BROKEN must be enabled, then that's the way it is.
>          ^^^^^^
> Still funny...
> 
> So either one of them is lying...

They might be broken in other situations.  However, if you look at
the latest build at:

 http://armlinux.simtec.co.uk/kautobuild/

you'll notice that all, even the ones with CONFIG_BROKEN build
successfully.  Without any bug reports to the contary, we must
assume that the configuration files supplied by the folk who
developed the support for the platform are correct and working.

Therefore, CONFIG_BROKEN may have been added to configuration
options which don't work for some particular small corner cases.

This brings on to another subject.  If we mark something broken
we should say _why_ we're doing so, especially if it is non-obvious.
That seems to be the case here - if these drivers are broken, it's
non-obvious why they're broken.

So, all in all, CONFIG_BROKEN is a broken idea in itself!

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/