Re: [PATCH -mm 7/9] unshare system call : allow unsharing of namespace

From: JANAK DESAI
Date: Tue Dec 13 2005 - 09:10:43 EST


Al Viro wrote:

On Mon, Dec 12, 2005 at 10:00:09PM -0500, JANAK DESAI wrote:


[PATCH -mm 7/9] unshare system call: allow unsharing of namespace



You need a pointer to new fs_struct, since that's what will be modified.
As it is, you are modifying ->root, etc. of old fs_struct, which is OK
only when it's not shared.

What you need is to pass new_fs ? new_fs : current->fs as a separate
argument to your dup_namespace().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/




Thanks. I will make all the changes as per your feedback, re-test and resubmit the
series later today.

-Janak
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/