Re: Fwd: [RFC][PATCH] Prevent overriding of Symbols in the Kernel, avoiding Undefined behaviour

[Anand H. Krishnan]

Hi,

>
> 
> Hi,
>         The check for exportsym not being NULL is
> redundant, since
> mod->num_syms will be 0 in that case.  The cast is
> also redundant.  You
> have two identical failure cases at the bottom. 

All true and will be changed.

> your use of index
> is convoluted: do it after relocations.
> 

Though rare, we will have the extra overhead of
relocations before we fail the loading of the m
odule [with the advantage of a cleaner code]. I
s that OK ?



Thanks,
Anand



__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/