Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

From: Ingo Molnar
Date: Tue Dec 13 2005 - 04:13:35 EST



* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> >
> > Remove -Wdeclaration-after-statement
> >
> > Now that gcc 2.95 is not supported anymore it's ok to use C99
> > style mixed declarations everywhere.
>
> Nack. This code style is pure obsfucation and we should disallow it
> forever.

agreed. I often get quilt mismerges uncovered by that warning. If
someone wants to start a new section of code that is too large, it
should go into a separate function.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/