Re: [PATCH] Don't attempt to power off if power off is notimplemented.

From: Paul Jackson
Date: Sun Dec 11 2005 - 18:19:11 EST


> For architectures like alpha that don't implement the pm_power_off
> variable pm_power_off is declared in linux/pm.h and it is a generic
> part of our power management code, and all architectures should
> implement it.
>
> ...
>
> Andrew can you pick this up and put this in the mm tree. Kernels
> that don't compile or don't power off seem saner than kernels that
> oops or panic.

Ok - so now you've broken alpha build ;(.

Yes - as your patch comment explains, the alternatives suck worse.

I'll send a patch that provides a NULL pm_power_off pointer for alpha,
which in my 43 seconds of deep analysis of this issue, seems to be the
thing to do for arch's that don't define a useful pm_power_off.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/