Re: [patch 15/17] s390: convert /proc/cio_ignore.

From: Andrew Morton
Date: Sat Dec 10 2005 - 04:37:44 EST


Cornelia Huck <cornelia.huck@xxxxxxxxx> wrote:
>
> > Unneeded (and undesirable) cast of void*.
>
> Some people seem to prefer explicit casts to make the
> type more clear. Is there any concensus on this? (I don't care
> either way ;))

It's better to omit the casts because

a) they're ugly and

b) If someone changes the type of the RHS from void* to anything else,
we'll get a warning, probably leading us to a bug. The cast would have
prevented that warning. IOW, omitting the cast is more type-safe.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/