Re: [PATCH 1/3] i386: CS5535 chip support - cpu

[Pavel Machek]

On Wed 07-12-05 12:42:26, Jordan Crouse wrote:
> +/* Note - this does not check to see if the CS5535 actually exists */
> +
> +#define LO(b)  (((1 << b) << 16) | 0x0000)
> +#define HI(b)  ((0x0000 << 16) | (1 << b))
> +

What kind of ninja mutant macros are these?

> +static u32 intab[16] __initdata = {
> +	0x20,HI(3), 0x24,LO(3), 0x28,LO(3),
> +	0x2C,LO(3), 0x34,HI(3), 0x38,LO(3),
> +     0x40,LO(3), 0x44,LO(3)
> +};

Can't you just use values here, without the macros?

							Pavel
-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/