Re: set_page_dirty vs set_page_dirty_lock

From: Jens Axboe
Date: Thu Dec 08 2005 - 14:53:00 EST


On Thu, Dec 08 2005, Hugh Dickins wrote:
> It can be very inconvenient (I don't know what to do for drivers/scsi/sg.c
> than set_page_dirty and hope for the best, since it cannot wait for a lock
> where it needs to). But I'm afraid you do have the very case where
> set_page_dirty_lock is appropriate.

See bio_set_pages_dirty() in fs/bio.c and the framework for handling
those (notably bio_dirty_fn()).

> Many would be pleased if we could manage without set_page_dirty_lock.

Indeed, would make life easier there as well..

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/