Re: [Lhms-devel] Re: [PATCH] swap migration: Fix lru drain

From: KAMEZAWA Hiroyuki
Date: Thu Dec 08 2005 - 00:05:19 EST


Christoph Lameter wrote:
On Wed, 7 Dec 2005, Andrew Morton wrote:


I'll change this to return 0 on success, or -ENOMEM. Bit more
conventional, no?


Ok. That also allows the addition of other error conditions in the future.
Need to revise isolate_lru_page to reflect that.

I think this 'schedule_on_each_cpu(lru_add_drain_per_cpu, NULL);' will be used
by memory-hot-removing code and some other codes.
How about move this to swap.c and name as 'lru_add_drain_all()' ?
(but there is no other users now....)

-- Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/