Re: [patch] add two inotify_add_watch flags

[Robert Love]

On Tue, 2005-12-06 at 22:54 -0500, John McCutchan wrote:

> The below patch lets user space have more control over the inodes that
> inotify will watch. It introduces two new flags. 
> 
> 	IN_ONLYDIR -- only watch the inode if it is a directory
> 	This is needed to avoid the race that can occur when we want to be sure
> that we are watching a directory.
> 
> 	IN_DONT_FOLLOW -- don't follow a symlink. In combination with
> IN_ONLYDIR we can make sure that we don't watch the target of symlinks.
> 
> The issues the flags fix came up when writing the gnome-vfs inotify
> backend. Default behaviour is unchanged.

Looks good to me, and I confirm we hit these issues in real-life with
gnome-vfs.

Acked-by: Robert Love <rml@xxxxxxxxxx>

	Robert Love


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/