Re: [PATCH 2.6-git] SPI core refresh

From: David Brownell
Date: Sat Dec 03 2005 - 18:50:12 EST


On Saturday 03 December 2005 9:10 am, Mark Underwood wrote:
>
> David, how would you feel about adding a NOT_DMAABLE flag in the spi_message structure?

Not good; it'd mean that every controller driver would have to support
both PIO and DMA modes. This minor issue (despite the noise!) isn't
worth making such an intrusive demand on all drivers.


> The other solution is to do a kmalloc for each caller (would could try to be smart and only do
> that if the buffer is being used).

That's far preferable. You could just submit the patch against rc3-mm1
and that'll do the job.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/