Re: [discuss] Re: [patch 1/3] x86_64: Node local PDA -- early cpu_to_node

From: Andi Kleen
Date: Fri Dec 02 2005 - 18:48:09 EST


On Fri, Dec 02, 2005 at 03:43:30PM -0800, Ravikiran G Thirumalai wrote:
> On Sat, Dec 03, 2005 at 12:02:06AM +0100, Andi Kleen wrote:
> > On Fri, Dec 02, 2005 at 02:51:56PM -0800, Ravikiran G Thirumalai wrote:
> > > On Fri, Dec 02, 2005 at 12:43:49PM +0100, Andi Kleen wrote:
> > > > And are you sure it will work with k8topology.c. Doesn't look like
> > > > that to me.
> > >
> > > I don't have a K8 box yet :(, so I cannot confirm either ways.
> > > But I thought newer opterons need to use ACPI_NUMA instead...
> >
> > k8topology still needs to work - e.g. for LinuxBios and users which use
> > acpi=off and as a fallback for broken SRAT tables. You can't break it right now.
> >
>
> I don't think this breaks K8 per-se, because x86_cpu_to_apicid[] is setup if
> acpi is compiled in and k8topology sets up apicid_to_node[] at
> k8_scan_nodes. That said, I don't know for sure as I don't have a K8 yet. If
> someone can test this patch on a opteron, compiled with
> ACPI_NUMA as well as K8, (but which falls back to K8 at boot),
> it will be helpful.

I can do that with the next patch.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/