Re: Two module-init-

From: Rusty Russell
Date: Thu Dec 01 2005 - 19:12:28 EST


On Wed, 2005-11-30 at 14:09 +0000, Scott James Remnant wrote:
> Hi Rusty,
>
> Attached are two patches to module-init-tools from Ubuntu.
>
> The first (input_table_size) is a catch-up with 2.6.15, it's adding an
> extra field to the input_device_id struct; m-u-t needs updating to be
> able to read the modules correctly.

Hi Scott,

Unfortunately, it's not that simple. Your patch will break previous
kernels, which have a smaller structure. I've had the discussion years
ago with the input people on using module aliases, and it's not entirely
trivial. I will prepare another patch, however.

Meanwhile, as noone seems to use swbit in struct input_device_id,
perhaps we can remove it for 2.6.15?

> The second (use_blacklist) adds a "-b" flag to modprobe that performs
> blacklist checking on those modules listed on the command line, it's
> handy for use when calling modprobe from udev for those subsystems
> without MODALIAS yet (input, ccw, etc.)

Hmm, well, the answer to that is the same as above. ccw should have
support now, so it's just input we're missing I think.

Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/