Re: 2.6.15-rc3-mm1

From: Kilau, Scott
Date: Thu Dec 01 2005 - 17:55:55 EST



> On Fri, Dec 02, 2005 at 08:10:59AM +1100, Benjamin Herrenschmidt
wrote:
> > On Thu, 2005-12-01 at 11:31 +0000, Christoph Hellwig wrote:
> > On Thu, Dec 01, 2005 at 10:18:25AM +1100, Benjamin Herrenschmidt
wrote:

> > Hrm... ok, well, we have a board here based on Exar chips that can
be
> > driven by the "jsm" driver but it also works fine with 8250...

> ok, then there's probably a dumb mode aswell :)

Hi Christoph, all,

This is true.

There is a 8250 "legacy" mode with this Exar chip, but they have
also tossed in a bunch of extra UART "features" to make the product
almost quasi-intelligent.

The JSM driver attempts to use these features as much as possible,
which does happen to "abuse" the tty interface in an attempt to get
serial throughput to 921K against all 8 ports bidirectionally.

Using the old flip buffers (not the *new* Alan Cox stuff!) would
Limit throughput to about 460K against all 8 ports bidirectionally.

The "abuse" was to avoid using flip buffers if the driver can do
so, and calling the ld's receive_buf function directly, rather
than having the flip buffers do it.

This method was (and still is) being used by other serial drivers
in the kernel, under a long-ago made comment by Theodore Tso that
it was valid to do so.

I agree that all this confusing and "abusive" logic can go away
now, now that Alan has changed the old tty flip stuff.
(Thanks Alan! It was VERY much needed!)

IBM is working on a patch to yank all this unneeded logic out
as we speak.

BTW,
Is there any timeframe when the Alan Cox flip buffer/tty change will
make it from mm into the stock kernel?

Thanks!
Scott Kilau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/