Re: Fix handling of ELF segments with zero filesize

From: Willy Tarreau
Date: Thu Dec 01 2005 - 00:46:03 EST


On Thu, Dec 01, 2005 at 04:36:41PM +1100, David Gibson wrote:
> On Thu, Dec 01, 2005 at 06:26:42AM +0100, Willy Tarreau wrote:
> > On Thu, Dec 01, 2005 at 11:20:49AM +1100, David Gibson wrote:
> > > Andrew, please apply
> > >
> > > mmap() returns -EINVAL if given a zero length, and thus elf_map() in
> > > binfmt_elf.c does likewise if it attempts to map a (page-aligned) ELF
> > > segment with zero filesize. Such a situation never arises with the
> > > default linker scripts, but there's nothing inherently wrong with
> > > zero-filesize (but non-zero memsize) ELF segments. Custom linker
> > > scripts can generate them, and the kernel should be able to map them;
> > > this patch makes it so.
> >
> > David, 2.4 has exactly the same code, do you see anything wrong with
> > applying this patch to 2.4 too ?
>
> Nothing that I can think of.

Thanks, I'm queueing it for -hf and will resend it to Marcelo if he
misses it.

Regards,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/