Re: [git pull 09/14] Uinput: add UI_SET_SWBIT ioctl

From: Dmitry Torokhov
Date: Wed Nov 23 2005 - 18:12:11 EST


On 11/23/05, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
> Oh,and ... ARGH !
>
> So you pass that nice structure
>
> struct input_event {
> struct timeval time;
> __u16 type;
> __u16 code;
> __s32 value;
> };
>
> to userland via read() ... cool, a structure that is not compatible
> between 32 and 64 bits passed around via a read call. that will be fun
> to fix.
>

It would need the same treatment as evdev got. Entire uinput is not
32/64 bit friendly (hostorically). However, it should be used by an
userspace "driver", not an ordinary program, so we probably shoudl
just require using native-sized binary with uinput.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/