Re: pivot_root broken in 2.6.15-rc1-mm2

From: Al Viro
Date: Tue Nov 22 2005 - 21:15:23 EST


On Wed, Nov 23, 2005 at 01:07:28PM +1100, Neil Brown wrote:
> After putting in copious tracing printk, the offending test is:
>
> if (user_nd.mnt->mnt_parent == user_nd.mnt)
> goto out2; /* not attached */
>
> If I remove this, it works (or seems to).
> Presumably the initial root file system is 'not attached'. But that
> shouldn't be a problem, should it?

Initial root is root and will remain root, period.

> Could this be related to the new shared mounts stuff???

No. And no, it's not going to change - any memory you win on killing
initramfs is not going to be worth the extra code needed to special-case
it.

pivot_root() does work in chroot jail (including the one we get after
chrooting to "final" root), but that's all it does.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/