Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)

From: Daniel Marjamäki
Date: Mon Nov 21 2005 - 03:09:17 EST




Bodo Eggert wrote:
Daniel Marjamäki <daniel.marjamaki@xxxxxxxxx> wrote:


- aztTimeOutCount = 0;
+ aztTimeOut = jiffies + 2;


Different timeout based on HZ seems wrong.

Yes, but..

If I'd say "HZ/100", then all systems that uses my driver must have HZ>=200.

The way I do it:
All systems will give me a delay for at least a few ms.
I get the shortest timeout possible on each computer.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/