Re: dma_is_consistent() is nonsensical...

From: Krzysztof Halasa
Date: Thu Nov 17 2005 - 14:51:44 EST


Deepak Saxena <dsaxena@xxxxxxxxxxx> writes:

> Working on adding support for cache-coherent operation to ARM and
> wondering exactly what this API is supposed to do. From the name it
> is obviously supposed to tell the caller (only one in the kernel...
> drivers/scsi/53c700.c) whether the provided dma_handle is cache-coherent
> or not. In the case of multiple DMA domains where certain devices
> are on snooping interfaces and others are not we really want to know what
> device the DMA address is on so can we add a struct device* ptr to this
> function? Or can we just kill it since nobody is actually using it?
> Calling dma_alloc_coherent should always return coherent/consistent
> (why the different naming conventions too?) so I don't really see a real
> use case.

I would have to look at the current code but yes, there were issues
like that in the past. Coherent vs consistent - there are two APIs
(DMA and PCI) each with a different name for this.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/