[PATCH 1/10] kdump: i386 save ss esp bug fix

From: Vivek Goyal
Date: Thu Nov 17 2005 - 08:18:08 EST





o This patch fixes a minor bug based on Andi Kleen's suggestion. asm's can't
be broken in this particular case, hence merging them.

Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
---

linux-2.6.15-rc1-1M-dynamic-root/arch/i386/kernel/crash.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff -puN arch/i386/kernel/crash.c~kexec-i386-ss-esp-bug-fix arch/i386/kernel/crash.c
--- linux-2.6.15-rc1-1M-dynamic/arch/i386/kernel/crash.c~kexec-i386-ss-esp-bug-fix 2005-11-15 12:29:53.000000000 +0530
+++ linux-2.6.15-rc1-1M-dynamic-root/arch/i386/kernel/crash.c 2005-11-15 14:01:21.000000000 +0530
@@ -108,8 +108,10 @@ static void crash_setup_regs(struct pt_r
{
memcpy(newregs, oldregs, sizeof(*newregs));
newregs->esp = (unsigned long)&(oldregs->esp);
- __asm__ __volatile__("xorl %eax, %eax;");
- __asm__ __volatile__ ("movw %%ss, %%ax;" :"=a"(newregs->xss));
+ __asm__ __volatile__(
+ "xorl %%eax, %%eax\n\t"
+ "movw %%ss, %%ax\n\t"
+ :"=a"(newregs->xss));
}

/* We may have saved_regs from where the error came from
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/