Re: [RFC] [PATCH 12/13] Change pid accesses: ia64 and mips

From: Serge E. Hallyn
Date: Wed Nov 16 2005 - 08:52:27 EST


Quoting Keith Owens (kaos@xxxxxxx):
> On Mon, 14 Nov 2005 15:23:53 -0600,
> "Serge E. Hallyn" <serue@xxxxxxxxxx> wrote:
> >Index: linux-2.6.15-rc1/arch/ia64/kernel/mca.c
> >===================================================================
> >--- linux-2.6.15-rc1.orig/arch/ia64/kernel/mca.c
> >+++ linux-2.6.15-rc1/arch/ia64/kernel/mca.c
> >@@ -755,9 +755,9 @@ ia64_mca_modify_original_stack(struct pt
> > * (swapper or nested MCA/INIT) then use the start of the previous comm
> > * field suffixed with its cpu.
> > */
> >- if (previous_current->pid)
> >+ if (previous_task_pid(current))
> > snprintf(comm, sizeof(comm), "%s %d",
> >- current->comm, previous_current->pid);
> >+ current->comm, previous_task_pid(current));
> > else {
> > int l;
> > if ((p = strchr(previous_current->comm, ' ')))
>
> That makes no sense, previous_task_pid() is not defined anywhere.
> Looks like a global edit error and should probably be
> task_pid(previous_current).

Note there are a few more ia64 errors - working on a test compile
now and will send out a new patch, though i don't have the hw to
boot-test.

thanks,
-serge

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/