Re: [PATCH 1/5] Light Fragmentation Avoidance V20:001_antidefrag_flags

[Paul Jackson]

Mel wrote:
>  #define __GFP_VALID	((__force gfp_t)0x80000000u) /* valid GFP flags */
>  
> +/*
> + * Allocation type modifier
> + * __GFP_EASYRCLM: Easily reclaimed pages like userspace or buffer pages
> + */
> +#define __GFP_EASYRCLM   0x80000u  /* User and other easily reclaimed pages */
> +

How about fitting the style (casts, just one line) of the other flags,
so that these added six lines become instead just the one line:

   #define __GFP_EASYRCLM   ((__force gfp_t)0x80000u)  /* easily reclaimed pages */

(Yeah - it was probably me that asked for -more- comments sometime in
the past - consistency is not my strong suit ;).

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/