Re: [PATCH 1/10] Cr4 is valid on some 486s

[Roland Dreier]

    > +#define alternative_smp(smpinstr, upinstr) asm(upinstr, ##input)

this wouldn't build with CONFIG_SMP=n -- you forgot the input param here.

also, given this:

    > +		BUG_ON(a->replacementlen > a->instrlen); 

is there any way to at least catch it at compile time if the UP
alternative ends up longer than the SMP alternative?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/