Re: [PATCH 2/4] register_ and unregister_memory_notifier should beglobal

From: Andrew Morton
Date: Mon Nov 14 2005 - 18:22:52 EST


Andy Whitcroft <apw@xxxxxxxxxxxx> wrote:
>
> Both register_memory_notifer and unregister_memory_notifier are global
> and declared so in linux.h. Update the HOTPLUG specific definitions
> to match. This fixes a compile warning when HOTPLUG is enabled.
>

There is no linux.h and I can find no .h file which declares
register_memory_notifier(). Please clarify?


> ---
> memory.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff -upN reference/drivers/base/memory.c current/drivers/base/memory.c
> --- reference/drivers/base/memory.c
> +++ current/drivers/base/memory.c
> @@ -50,12 +50,12 @@ static struct kset_hotplug_ops memory_ho
>
> static struct notifier_block *memory_chain;
>
> -static int register_memory_notifier(struct notifier_block *nb)
> +int register_memory_notifier(struct notifier_block *nb)
> {
> return notifier_chain_register(&memory_chain, nb);
> }
>
> -static void unregister_memory_notifier(struct notifier_block *nb)
> +void unregister_memory_notifier(struct notifier_block *nb)
> {
> notifier_chain_unregister(&memory_chain, nb);
> }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/