Re: [PATCH 0/12] FS-Cache: Generic filesystem caching facility

[Andrew Morton]

Linus Torvalds <torvalds@xxxxxxxx> wrote:
>
> On Mon, 14 Nov 2005, David Howells wrote:
> >
> > This series of patches does four things:
> 
> Ok, interesting, and I like most of what I see..

Less impressed.  It (still) adds a very large amount of tricksy code which
pokes around in core pagecache functions, slows down the radix-tree
hotpath, exports mysterious symbols.  And that's on a 60-second scan. 

It'll be a sizeable job going through it in detail.  Not as sizeable as
writing it though ;)

All of this for an undisclosed speedup of AFS!

I think we need an NFS implementation and some numbers which make it
interesting.  Or at least, some AFS numbers, some explanation as to why
they can be extrapolated to NFS and some degree of interest from the NFS
guys.   Ditto CIFS.

Because it _is_ a lot of code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/